Sign out and i18n #700
Merged
Sign out and i18n #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
==========================================
- Coverage 87.28% 87.06% -0.23%
==========================================
Files 72 74 +2
Lines 3429 3494 +65
Branches 652 668 +16
==========================================
+ Hits 2993 3042 +49
- Misses 419 435 +16
Partials 17 17
Continue to review full report at Codecov.
|
This was referenced Mar 14, 2021
Merged
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
to sign out user correctly, move i18n to common and add unit tests for i18n
Description of changes:
When only using auth, the credentials_source will be null once reloaded which causes the
user.signOut()not calledBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.